Improve UID file creation condition #102489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiroxas
reviewed
Feb 6, 2025
KoBeWi
force-pushed
the
uid_file_factory_regulations
branch
from
50c470c to
65509ae
Compare
akien-mga
approved these changes
Feb 6, 2025
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
…gulations Improve UID file creation condition
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102465
The original code used
ResourceLoader::existsand thenResourceLoader::has_custom_uid_support, which means it traversed all loaders twice to check whether the file is recognized and can generate .uid file. I added a new method that does it within a single loop and prevents creating .uid file if no loader recognized the resource.