Fix TextEdit cusor shape when mouse is held #102556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:gui
cherrypick:4.3
KoBeWi
removed
the
cherrypick:4.4
kitbdev
force-pushed
the
fix-te-cursor-shape-held
branch
from
4980814 to
65b7e1c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting text with the mouse and the cursor goes outside the textbox to the left or over something clickable like the gutters, the mouse cursor should not change.
Same with dragging the minimap, the cursor should always be the same while the mouse is held down.
I think
dragging_selectionshouldn't be set when dragging text, but changing it could affect other logic, so for now I just make sure to set it to false when dragging ends. Otherwise it could be in the wrong state. This could be seen by moving some text and immediately ctrl+click on something, it doesn't work.