Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add Snackbar UI component #102590

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Feb 8, 2025

This PR introduces a Snackbar UI component, providing a native, touch-friendly in-app notification system. The Snackbar is designed to display temporary messages without blocking user interaction and includes an optional action button. It can be dismissed after a certain duration or by swiping.

I would like to integrate this into some parts of the Android Editor. However, since we are currently in a feature freeze, this PR only adds the component itself without exposing it or integrating it into the Android Editor yet. The integration will be done in follow-up PRs as needed during the 4.5 dev cycle.

Currently, this Snackbar is needed for and will be used in #102492.

Screenrecorder-2025-02-08-19-24-56-778.mp4

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga
Copy link
Member

akien-mga commented Feb 10, 2025

Clarifying for other reviewers that we're in feature freeze, so normally such additions would be out of scope. But we're making an exception here for two reasons:

  • This is needed for a good UX in Add support for embedding game process in the Android Editor #102492, which implements feature parity for the Android editor with the embedded game process added for Windows and Linux in 4.4. So it's technically completing a 4.4 feature for one platform.
  • The Android editor is still experimental and the Android team maintainers support this late addition, so we defer to them. This doesn't affect other platforms.

@akien-mga akien-mga merged commit eb4538b into godotengine:master Feb 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@syntaxerror247 syntaxerror247 deleted the custom-snackbar branch February 10, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants