Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse input on popup shadows misbehaving with content_scale_factor #102625

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix mouse input on popup shadows misbehaving with content_scale_factor #102625

merged 1 commit into from
Feb 11, 2025

Conversation

YeldhamDev
Copy link
Member

Fixes #102159.

@YeldhamDev YeldhamDev added this to the 4.4 milestone Feb 9, 2025
@YeldhamDev YeldhamDev requested a review from a team as a code owner February 9, 2025 18:03
@YeldhamDev YeldhamDev mentioned this pull request Feb 9, 2025
Merged
@YeldhamDev YeldhamDev marked this pull request as draft February 9, 2025 23:30
@YeldhamDev YeldhamDev force-pushed the oh_those_wacky_shadows branch from fb13d4a to a32d366 Compare February 10, 2025 14:55
@YeldhamDev YeldhamDev changed the title Fix popup hide-on-shadow-click behavior ignoring content_scale_factor Fix popup shadows misbehaving with content_scale_factor Feb 10, 2025
@YeldhamDev YeldhamDev marked this pull request as ready for review February 10, 2025 14:56
@Jowan-Spooner
Copy link

Thank you so much! Can confirm that this fixes my MRP (tested with the build artifact on Windows 10).

@akien-mga akien-mga requested review from KoBeWi and bruvzg February 11, 2025 16:26
bruvzg
bruvzg approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue.

The name of the commit might be a bit misleading, it's not clear that it's an input issue, not a rendering issue.

@akien-mga akien-mga changed the title Fix popup shadows misbehaving with content_scale_factor Fix mouse input on popup shadows misbehaving with content_scale_factor Feb 11, 2025
@akien-mga
Copy link
Member

I tweaked the PR title to clarify, should be fine.

@akien-mga akien-mga merged commit ed79fe1 into godotengine:master Feb 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the oh_those_wacky_shadows branch February 11, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@KoBeWi KoBeWi Awaiting requested review from KoBeWi

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Popup menus broken when content_scale_mode is bigger then 1 and subwindows are not embedded
4 participants
@YeldhamDev @Jowan-Spooner @akien-mga @bruvzg