C#: Validate project TFM for Android template exports #102627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Feb 10, 2025
| print_line(pipe); | ||
| WARN_PRINT("dotnet command exited with code " + itos(exitcode) + ". See output above for more details."); | ||
| } | ||
| r_error += TTR("Unable to determine the C# project's TFM, it may be incompatible. The export template only supports '" + required_tfm + "'. Make sure the project targets '" + required_tfm + "' or consider using gradle builds instead.") + "\n"; |
There was a problem hiding this comment.
Suggested change
| r_error += TTR("Unable to determine the C# project's TFM, it may be incompatible. The export template only supports '" + required_tfm + "'. Make sure the project targets '" + required_tfm + "' or consider using gradle builds instead.") + "\n"; | |
| r_error += vformat(TTR("Unable to determine the C# project's TFM, it may be incompatible. The export template only supports '%s'. Make sure the project targets '%s' or consider using gradle builds instead."), required_tfm, required_tfm) + "\n"; |
Afaik, the translation won't work otherwise I think
There was a problem hiding this comment.
Indeed, TTR() strings are extracted as is by a Python parser, so they need to be literals.
| } else { | ||
| String tfm = pipe.strip_edges(); | ||
| if (tfm != required_tfm) { | ||
| r_error += TTR("C# project targets '" + tfm + "' but the export template only supports '" + required_tfm + "'. Consider using gradle builds instead.") + "\n"; |
There was a problem hiding this comment.
Suggested change
| r_error += TTR("C# project targets '" + tfm + "' but the export template only supports '" + required_tfm + "'. Consider using gradle builds instead.") + "\n"; | |
| r_error += vformat(TTR("C# project targets '%s' but the export template only supports '%s'. Consider using gradle builds instead."), tfm, required_tfm) + "\n"; |
The C# Android export template includes `.jar` dependencies from .NET 8.0, so other TFMs are not supported.
raulsntos
force-pushed
the
dotnet/android-export-validate-tfm
branch
from
f75fee5 to
70ff213
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C# Android export template includes
.jardependencies from .NET 8.0, so other TFMs are not supported.The error messages assume #98066 will be merged so this won't be a problem for Gradle builds.
I don't like that we keep introducing more .NET-specific stuff on the Android platform. Maybe we can expose some virtual method on
EditorExportPluginto do this validation on the plugin's side, then it could be implemented entirely onExportPlugin.cs, but this can be postponed to 4.5+.Bugsquad edit: