Betsy: Remove OGRE aliases #102667
Open
Betsy: Remove OGRE aliases #102667
+219
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
I scrolled through the changeset. I think that the uint2 to uvec2 operations and such are fine but it was surprising to see them since the pull request title was saying a rename and not some misc updates to the code. So I would try to amend the commit log / title to be more accurate to what was done.
Did not test the code.
|
Makes sense to me on the principle. Let us know when this is tested further and ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the OGRE function/type aliases from Betsy. (See #102264 (comment))
TODO: