-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert finalizing GodotHost#getCommandLine()
public API
#102669
Revert finalizing GodotHost#getCommandLine()
public API
#102669
Conversation
@dsnopek Note that I'm keeping the update to |
This comment was marked as resolved.
This comment was marked as resolved.
GodotHost#getCommandLine()
public API
fe228c9
to
d6c8c02
Compare
@m4gr3d This still leaves the return type of If our goal is that we don't want Android plugins written for Godot 4.3 to require source changes to compile, then we should probably revert the change to the return type as well. |
When building godot_openxr_vendors against these changes, I'm also getting an error about UPDATE: You can see all the changes needed to godot_openxr_vendors in PR GodotVR/godot_openxr_vendors#266 |
d6c8c02
to
2a66335
Compare
@dsnopek I've addressed your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The latest version works great in my testing
Thanks! |
Fix API regression issue reported in GodotVR/godot_openxr_vendors#264