Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2D: Fix free of invalid ID #102677

Merged
merged 1 commit into from
Feb 11, 2025
Merged

2D: Fix free of invalid ID #102677

merged 1 commit into from
Feb 11, 2025

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Feb 10, 2025 •
edited
Loading

Release the callback for the default texture to avoid double free when destructing RendererCanvasRenderRD

Closes #102670

@stuartcarnie stuartcarnie requested a review from a team as a code owner February 10, 2025 21:18
@stuartcarnie stuartcarnie mentioned this pull request Feb 10, 2025
Closed
@akien-mga akien-mga added this to the 4.4 milestone Feb 10, 2025
@akien-mga akien-mga merged commit cfe0fd6 into godotengine:master Feb 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@JekSun97
Copy link
Contributor

I noticed that canvas_texture_free is executed after canvas_texture_set_invalidation_callback, is that supposed to happen? Aren't we losing the reference to default_canvas_texture in canvas_texture_set_invalidation_callback?

@stuartcarnie stuartcarnie deleted the free_invalid_id branch February 12, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

"Attempted to free invalid ID" errors are printed when exiting a project run with Debug Canvas Item Redraw
4 participants
@stuartcarnie @akien-mga @JekSun97 @clayjohn