Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve path handling in EditorQuickOpenDialog #102678

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Feb 10, 2025

  • Store path history as UIDs
    • Allows "auto-update" paths when files are moved, so your history items won't break
  • Support UID paths in the dialog
  • When loading history, remove files that no longer exist
    • Only happens at first opening. If a file is gone between openings and you try to open wrong file, error dialog appears and the entry is deleted

I also added get_file_uid() method to EditorFileSystem, which is faster than going through ResourceLoader. We should use it from now where applicable.

@KoBeWi KoBeWi added this to the 4.x milestone Feb 10, 2025
@KoBeWi KoBeWi requested review from a team as code owners February 10, 2025 21:20
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since both the new Quick Open dialog and generalized UIDs are new features in 4.4, I think we can get this merged for 4.4 too to fine-tune the experience.

That being said feel free to set it for 4.5 if you think this should bake some more before merging.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Feb 10, 2025
@akien-mga akien-mga merged commit b1b9a17 into godotengine:master Feb 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the uid_open_dialog branch February 11, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants