Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inspector revert and animation keying button sizing #102681

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Feb 10, 2025

Fixes: #102629

This PR also replaces: #94742

Button are now bigger, full height, and they have a hover background to make it more obvious where to click.

Screencast_20250209_031302.webm

Also fixes an issue with hover state being wrong.
If you moved mouse quickly over a button they would stay in the hover state.

I didn't change the styling of checkable. As I don't know how or where this is displayed. Let me know if this should be applied to that one too.

@AThousandShips AThousandShips requested a review from a team February 11, 2025 09:01
@AThousandShips AThousandShips added bug topic:editor usability cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Feb 11, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Feb 11, 2025
@Giganzo Giganzo force-pushed the inspector-overlay-buttons branch from 53f8e7b to 5dabc36 Compare February 15, 2025 11:28
@akien-mga akien-mga changed the title Fix Inspector animation key button sizing Fix Inspector revert and animation keying button sizing Feb 15, 2025
@akien-mga akien-mga merged commit 10bb786 into godotengine:master Feb 15, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animation: To insert key, you must click precisely on the key icon rectangle near Inspector property
4 participants