Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus being lost after adding a new input map entry in the editor #102683

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 11, 2025

This allows adding multiple actions in a row by pressing Enter after each action, without needing to click the field again every time.

Preview

input_map_add_action.mp4

This allows adding multiple actions in a row by pressing Enter
after each action, without needing to click the field again
every time.
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though we were discussing possibly defaulting that property to true to preserve compatibility with 4.3.

But for now we can merge this fix.

@akien-mga akien-mga merged commit dd8a55d into godotengine:master Feb 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-input-map-keep-focus-on-new-entry branch February 17, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add New Action" text input loses focus upon adding a new input action
2 participants