Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select invisible items in FileSystem dock #102714

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Feb 11, 2025

Fixes #102690

Note that ideally invisible items should not get selected at all, but I couldn't easily find how Tree selects items. I opened #102713 to track it.

@KoBeWi KoBeWi added this to the 4.4 milestone Feb 11, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner February 11, 2025 15:32
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the problem

@akien-mga akien-mga merged commit 08f22c8 into godotengine:master Feb 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the ninja_tree_items_on_their_way_to_break_your_selection branch February 11, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File System Shift selecting filtered files selects unfiltered files
3 participants