Store _custom_type_script meta as String
#102737
Merged
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Feb 12, 2025
Comment on lines
+302
to
+307
| if (custom_script.get_type() == Variant::OBJECT) { | ||
| // Convert old script meta. | ||
| Ref<Script> script_object(custom_script); | ||
| assign_custom_type_script(const_cast<Object *>(p_object), script_object); | ||
| return script_object; | ||
| } |
There was a problem hiding this comment.
Bonus conversion code, only relevant for Resources/Nodes created in 4.4.
KoBeWi
force-pushed
the
uids_are_creeping_everywhere
branch
from
24c20d6 to
38d0e82
Compare
akien-mga
approved these changes
Feb 12, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102551
Makes custom type script stored as Script's UID instead of reference. This avoids all issues with accidental saving of script (like #100154, so #101001 is no longer needed for this particular case).