Add tooltip text to Polygon3DEditor buttons #102760
Conversation
| @@ -535,12 +535,14 @@ Polygon3DEditor::Polygon3DEditor() { | |||
|
|
|||
| button_create = memnew(Button); | |||
| button_create->set_theme_type_variation(SceneStringName(FlatButton)); | |||
| button_create->set_tooltip_text(TTR("Create Polygon")); | |||
There was a problem hiding this comment.
| button_create->set_tooltip_text(TTR("Create Polygon")); | |
| button_create->set_tooltip_text(TTRC("Create Polygon")); |
There was a problem hiding this comment.
TTR is correct. TTRC is for static C string literals, to mark them that they will later be translated, and does not actually translate the string.
There was a problem hiding this comment.
And this prevents double translation. See #99158 (or, for example, #101427 (comment)).
There was a problem hiding this comment.
Ok, I did check set_tooltip_text's implementation before commenting, which appeared not to translate. But it appears it does propagate tooltip_auto_translate_mode into Node::set_auto_translate_mode which does schedule translations (if auto). set_tooltip_text is used with TTRC sometimes (though TTR is used most times), so it's probably OK to change to TTRC.
There was a problem hiding this comment.
Made the suggested changes to use TTRC instead of TTR.
Giganzo
force-pushed
the
csg-toolbar-tooltips
branch
from
320c587 to
030d63e
Compare
|
Thanks! |
Fixes: #102759
After
Screencast_20250210_052335.webm