Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Add missing opened file check. #102803

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 13, 2025

Fixes #102795

@bruvzg
Copy link
Member Author

bruvzg commented Feb 13, 2025

Checked 4.2 and 4.1, and both have the same behavior, so this is relevant for all 4.x versions. 3.x are not affected due to existence of core_bind wrapper over FileAccess.

@bruvzg bruvzg added cherrypick:4.1 cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Feb 13, 2025
@Repiteo Repiteo merged commit b3feaab into godotengine:master Feb 13, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 13, 2025

Thanks!

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release crash platform:windows topic:porting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File open, get_as_text, close, then get_as_text again crashes just the app window but with no errors shown
4 participants