Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion: Override context for preload #102826

Merged
merged 1 commit into from
Feb 13, 2025
+3 −2
Merged

Autocompletion: Override context for preload #102826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/gdscript/gdscript_editor.cpp
View file
Original file line number Diff line number Diff line change
@@ -878,8 +878,7 @@ static void _get_directory_contents(EditorFileSystemDirectory *p_dir, HashMap<St
if (requires_type && !ClassDB::is_parent_class(p_dir->get_file_type(i), p_required_type)) {
continue;
}
ScriptLanguage::CodeCompletionOption option(p_dir->get_file_path(i), ScriptLanguage::CODE_COMPLETION_KIND_FILE_PATH);
option.insert_text = option.display.quote(quote_style);
ScriptLanguage::CodeCompletionOption option(p_dir->get_file_path(i).quote(quote_style), ScriptLanguage::CODE_COMPLETION_KIND_FILE_PATH);
r_list.insert(option.display, option);
}

2 changes: 2 additions & 0 deletions modules/gdscript/gdscript_parser.cpp
View file
Original file line number Diff line number Diff line change
@@ -3487,6 +3487,8 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_preload(ExpressionNode *p_

if (preload->path == nullptr) {
push_error(R"(Expected resource path after "(".)");
} else if (preload->path->type == Node::LITERAL) {
override_completion_context(preload->path, COMPLETION_RESOURCE_PATH, preload);
}

pop_completion_call();