Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Game embedding not available" message on Wayland #102833

Merged

Conversation

Hilderin
Copy link
Contributor

@Hilderin Hilderin commented Feb 14, 2025

This PR only adjusts the warning message to "Game Embedding not available on your OS" when using Wayland, making it more specific. The previous message was not entirely accurate since the embedding is available on Linux but not on Wayland.

This is the new warning message, I think it could be better but I'm not inspired:
image

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the message is fine. Its clear and tells the user what to do to avoid the problem

@akien-mga
Copy link
Member

Makes sense to me.

How does it behave if the editor runs X11, but the game itself is configured to use Wayland? This would be set in project settings for the game, and would mean trying to embed a Wayland window in the X11 editor. Do we support that scenario?

@Hilderin Hilderin force-pushed the fix-game-embeddeing-not-available-wayland branch from 86849cb to e97f95d Compare February 14, 2025 13:59
@Hilderin
Copy link
Contributor Author

Hilderin commented Feb 14, 2025

@akien-mga
That is an excellent question! Nobody thought about this situation before! I tested it, and even on Windows, when the selected display server is 'headless,' the Embedded Window was trying to embed a nonexistent window.

I added another warning message when the Display Server in project setting is headless or wayland:
image

@Hilderin Hilderin force-pushed the fix-game-embeddeing-not-available-wayland branch from e97f95d to fe49507 Compare February 14, 2025 14:04
@Hilderin Hilderin force-pushed the fix-game-embeddeing-not-available-wayland branch from fe49507 to d9f6539 Compare February 14, 2025 14:09
@akien-mga akien-mga changed the title Fix Game Embedding Not Available message on Wayland Fix "Game embedding not available" message on Wayland Feb 14, 2025
@Repiteo Repiteo merged commit b2aae7b into godotengine:master Feb 14, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Game Embedding not available on your OS" EndeavorOS Hyprland
5 participants