-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Game embedding not available" message on Wayland #102833
Fix "Game embedding not available" message on Wayland #102833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the message is fine. Its clear and tells the user what to do to avoid the problem
Makes sense to me. How does it behave if the editor runs X11, but the game itself is configured to use Wayland? This would be set in project settings for the game, and would mean trying to embed a Wayland window in the X11 editor. Do we support that scenario? |
86849cb
to
e97f95d
Compare
@akien-mga I added another warning message when the Display Server in project setting is |
e97f95d
to
fe49507
Compare
fe49507
to
d9f6539
Compare
Thanks! |
This PR only adjusts the warning message to "Game Embedding not available on your OS" when using Wayland, making it more specific. The previous message was not entirely accurate since the embedding is available on Linux but not on Wayland.
This is the new warning message, I think it could be better but I'm not inspired:
