JavaClassWrapper: Allow handling exceptions (rather than just crashing) #102862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
java-class-wrapper-get-exception
branch
from
92be336 to
11d166b
Compare
dsnopek
force-pushed
the
java-class-wrapper-get-exception
branch
from
11d166b to
5d69d20
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on PR #102817, I've come to realize how important this addition is!
Currently, if a developer calls a Java method via
JavaClassWrapperthat causes an exception, their app will simply crash with this message in the logs (plus lots of other debug info):This PR will clear the exception (so the app doesn't crash) and provide access to it via
JavaClassWrapper.get_exception()so the developer can actually handle the exception.