Fix MinGW crash handler crashing during trace generation or producing empty trace. #102900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bruvzg
commented
Feb 15, 2025
bruvzg
commented
- Reverts libbacktrace: Update to upstream commit 1db85642e #100274 (it seems to always produce empty traces).
- Fixes freeing of the wrong pointer in some conditions.
akien-mga
approved these changes
Feb 15, 2025
bruvzg
force-pushed
the
fix_mingw_bt
branch
2 times, most recently
from
e5f9fd4 to
2d6467f
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.