Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent pending input event callbacks from erasing the window in the middle of a loop. #102993

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Prevent pending input event callbacks from erasing the window in the middle of a loop. #102993

merged 1 commit into from
Feb 19, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 18, 2025 •
edited
Loading

Fixes #102954

Input events can cause a window to close and be erased from the windows map, so calling it while iterating over the window map is not safe.

@bruvzg bruvzg added this to the 4.4 milestone Feb 18, 2025
@bruvzg bruvzg requested review from a team as code owners February 18, 2025 13:31
@Repiteo Repiteo merged commit e91493f into godotengine:master Feb 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 19, 2025

Thanks!

@Riteo Riteo mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash platform:linuxbsd platform:macos platform:windows topic:input
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Exit code 11 when changing language by gamepad
3 participants
@bruvzg @Repiteo @akien-mga