Fix Embedded Game startup location on Windows #103021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Feb 19, 2025
|
Thanks! |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the startup location of the Embedded Game on Windows.
I was able to reproduce the issue when using multiple monitors when the main monitor was on the right and when the editor was on the left monitor.
The issue was caused by a condition that skipped the offset recalculation when the game was embedded. This error was there since the beginning but was made apparent only since the input queue thread was detached between the editor and the game process, allowing the first game render to display before the editor reposition the game correctly.