Fix dynamic object light leaking in LightmapGI when Interior is enabled #103023
+37
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:rendering
topic:3d
cherrypick:4.4
100 tasks
Calinou
force-pushed
the
lightmapgi-interior-fix-dynamic-object-light-leaking
branch
from
9a60eda to
0f4a36a
Compare
When Interior is enabled, black out probes located near the LightmapGI's bounds so that dynamic objects don't receive lighting from them.
Calinou
force-pushed
the
lightmapgi-interior-fix-dynamic-object-light-leaking
branch
from
0f4a36a to
85d6fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Interior is enabled, black out probes located near the LightmapGI's bounds so that dynamic objects don't receive lighting from them.
Note that #83420 does not supersede this PR, as it never excludes the 8 probes located at the AABB's vertices which are required for probe interpolation to work. These probes cannot be removed, so instead, they need to be made black in interior scenes to avoid light leaks.
Testing project: lightmap-colors-3.zip
Preview
With no additional lightmap probes
With emissive object and LightmapProbe nearby
With emissive object, LightmapProbe nearby and sun
Display of the probes in the editor
With Generate Probes Subdiv = 4