Don't show Show in Filesystem Popup for empty frames in SpriteFrames editor

[matheusmdx]

Fix #103048

[kleonc]

Fixes the crash, as is. 👍

Minor thing, could be included in this PR: _menu_selected is connected to id_pressed, so its argument should be called p_id, not p_index. Also MENU_SHOW_IN_FILESYSTEM should be passed to add_icon_item as the id (third arg).

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Lines 1324 to 1325 in 45875c2

	menu->connect(SceneStringName(id_pressed), callable_mp(this, &SpriteFramesEditor::_menu_selected));
	menu->add_icon_item(get_editor_theme_icon(SNAME("ShowInFileSystem")), TTRC("Show in FileSystem"));

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Line 1335 in 45875c2

void SpriteFramesEditor::_menu_selected(int p_index) {

This works currently but is conceptually wrong and might get broken in case of adding more options.

Also I'd say ERR_FAIL_NULL(frame_texture) in the handler wouldn't hurt:

godot/editor/plugins/sprite_frames_editor_plugin.cpp

Lines 1337 to 1338 in 45875c2

	case MENU_SHOW_IN_FILESYSTEM: {
	String path = frames->get_frame_texture(edited_anim, right_clicked_frame)->get_path();

[akien-mga]

Minor thing, could be included in this PR

I suggest doing those changes in a follow-up PR so this one stays focused on the crash fix for 4.4.

[akien-mga]

Thanks!