Fix Embedded Game does not focus when mouse over on Windows #103052
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Seems to be working.
But I'm not sure if it's always desired, it can result in extremely annoying behavior with menus.
Screen.Recording.2025-02-20.100840.mp4
Probably should at least check it there are opened popups and not take focus. And maybe be configurable.
Hilderin
force-pushed
the
fix-embedded-game-mouse-over-not-focused-windows
branch
from
58a9ffb to
c7bc322
Compare
|
Good point!! We already checked for modal windows in |
bruvzg
approved these changes
Feb 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was fixed by adding a
SetForegroundWindowbefore theSetFocus. My guess is that's another side-effect of the input queue thread being detached between the editor and the embedded game process.