Fix particle not re-randomizing every emission #103068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkology
reviewed
Feb 20, 2025
| @@ -41,6 +41,9 @@ | |||
| void GPUParticles2D::set_emitting(bool p_emitting) { | |||
| // Do not return even if `p_emitting == emitting` because `emitting` is just an approximation. | |||
|
|
|||
| if (p_emitting && p_emitting != emitting && !use_fixed_seed) { | |||
There was a problem hiding this comment.
Suggested change
| if (p_emitting && p_emitting != emitting && !use_fixed_seed) { | |
| if (p_emitting && !emitting && !use_fixed_seed) { |
Looks like it could be simplified, right? The same is valid below.
QbieShay
force-pushed
the
fix-particle-rand2
branch
from
576ffba to
419e5c4
Compare
clayjohn
approved these changes
Feb 20, 2025
Comment on lines
+62
to
+63
| if (time == 0) { | ||
| _update_internal(); |
There was a problem hiding this comment.
This logic is carried over from CPUParticles3D. It seems correct to me, so let's keep it
|
Thanks @QbieShay ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102885
Supersedes #103008
And probably creates a million problems for me down the line 🥲