Style: Begin integrating simple clangd fixes #103075
Conversation
Repiteo
force-pushed
the
style/clangd-simple
branch
from
158cb1f to
473d6a3
Compare
Repiteo
force-pushed
the
style/clangd-simple
branch
from
473d6a3 to
3e167e3
Compare
Repiteo
force-pushed
the
style/clangd-simple
branch
from
3e167e3 to
cebc140
Compare
There was a problem hiding this comment.
This is nice, I'm looking forward to saner includes.
All the include changes I understood look sane. I can't guarantee correctness for every single one, but to be honest, if it compiles (on all platforms), and is less broad, it's good. Forward declare instead of include is especially appreciated.
Just one concern about the extern "C" change.
Repiteo
force-pushed
the
style/clangd-simple
branch
from
cebc140 to
11cc8a4
Compare
core/string/ustring.cpp
Outdated
| @@ -39,7 +39,7 @@ | |||
| #include "core/string/translation_server.h" | |||
| #include "core/string/ucaps.h" | |||
| #include "core/variant/variant.h" | |||
| #include "core/version_generated.gen.h" | |||
| #include "core/version.h" | |||
There was a problem hiding this comment.
Not strongly opposed to it, but why that change? The only macro used is from version_generated.gen.h so it's more specific.
There was a problem hiding this comment.
My thinking was the export pragma in version.h makes it so that file is "exposing" the generated file, so it can be used in its place similar to using typedef.h instead of specific std headers. That's not as easily conveyed though, so I'm fine reverting back to the generated file.
There was a problem hiding this comment.
Well it's not a bad idea, and the cost on compilation time should be similar either way.
As long as we keep version_hash.gen.h separate (which changes for every commit, and causes quite a bit of CI churn as we can't fully reuse the cache), it should be fine.
Repiteo
force-pushed
the
style/clangd-simple
branch
from
11cc8a4 to
f09ee01
Compare
.clangdfixes #100918In contrast to the above PR, this aims to focus almost exclusively on basic header-related changes identified via clangd. So while a similar amount of files were touched, the actual functionality should be effectively identical & help address our header include issues. The only two non-header changes were replacing
_DefaultComparatorwithComparator(dependant files can now includecore/typedefs.hinstead ofcore/templates/sort_array.h) & replacing__alignedwith the nativealignas(fits the redundancy-removal theme).