Add animation filtering to animation editor #103130
Conversation
| filter_track->set_placeholder(TTR("Filter Tracks")); | ||
| filter_track->connect(SceneStringName(text_changed), callable_mp((AnimationTrackEditor *)this, &AnimationTrackEditor::_on_filter_updated)); | ||
| filter_track->set_clear_button_enabled(true); | ||
| filter_track->hide(); |
There was a problem hiding this comment.
Same here: filter_track->set_tooltip_text(TTR("Filter tracks by name by entering part of their name."));
There was a problem hiding this comment.
"property or Node name" but i wonder if the entire NodePath from the root affects the filtering (did not see the code, sorry)
There was a problem hiding this comment.
Good point. It searches the whole property path which includes the node name and the property. I went for this:
filter_track->set_tooltip_text(TTR("Filter tracks by entering part of their node name or property."));
There was a problem hiding this comment.
well, my concern was if you want to filter properties for a Sprite node, but you also have tracks for childs of this node, those tracks may also appear here if the entire NodePath is used in the filtering, because RigidBody2D/Sprite2D/Light2D/SomeCollisionShape:disabled includes the word "Sprite" on it
There was a problem hiding this comment.
Hmm good point. Let me do a bit of testing on this tomorrow and get back to you.
There was a problem hiding this comment.
Notes:
- when you create a track for a node with % access it will use it. so the node path could be
"%Sprite2D:position" - when creating tracks to the property of a resource, it looks like this:
"%CollisionShape2D:shape:size"
There was a problem hiding this comment.
@MarianoGnu Looking this over I feel it's ok that it's using the whole path. It feels like there would be cases where users are expecting to be able to filter like that as well, so I'm not sure it makes sense to remove it. It makes more sense to me to leave it like this first and then change it if users report that it's not doing what they expect.
I don't understand your notes about % access. If I set a node to have % access it makes no difference to the track paths that get added to the animation player when I start animating its properties.
There was a problem hiding this comment.
Oh, i was just pointing out you may find strings like that 👍
In the case of %, not full path
In the case of subresources, several : simbols
Arnklit
force-pushed
the
filter-animations
branch
3 times, most recently
from
f68f2b0 to
ff8ff06
Compare
Arnklit
force-pushed
the
filter-animations
branch
from
ff8ff06 to
6bb7536
Compare
This adds track filtering to the Animation Editor. This will close godotengine/godot-proposals#11741
cW20avecEd.mp4
Note: Currently the filtering is a simple contains check. I had a go at using the fuzzy_search class for better filtering, but I wasn't getting great results. I'll look into that futher and add it in a later PR.