Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaders: Only convert default value to linear color if type hint is source_color #103201

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Shaders: Only convert default value to linear color if type hint is source_color #103201

merged 1 commit into from
Feb 27, 2025

Conversation

beicause
Copy link
Contributor

Fixes #103194

@beicause beicause requested a review from a team as a code owner February 23, 2025 04:01
@beicause beicause force-pushed the shaders-only-convert-source-color-linear branch from 2bd82a9 to 5ca3862 Compare February 23, 2025 04:36
@Chaosus Chaosus added this to the 4.4 milestone Feb 23, 2025
@Chaosus Chaosus requested a review from clayjohn February 23, 2025 08:01
Calinou
Calinou approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@clayjohn clayjohn modified the milestones: 4.4, 4.5 Feb 27, 2025
@clayjohn clayjohn added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Feb 27, 2025
@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Feb 27, 2025
@akien-mga akien-mga modified the milestones: 4.5, 4.4 Feb 27, 2025
@akien-mga akien-mga merged commit a9c5c4d into godotengine:master Feb 27, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@beicause beicause deleted the shaders-only-convert-source-color-linear branch February 28, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Shader Materials broken when created in C# (Regression from 4.4-beta2 -> 4.4-beta3)
5 participants
@beicause @akien-mga @Calinou @clayjohn @Chaosus