Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix error on subscript Class["member"] #103213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rune-scape
Copy link
Contributor

partially fixes #89350 (because its really an amalgam of inconsistencies in GDScript)

this uses the codepath for attributes when reducing an expression like Class["member"] (constant string)

basically avoids trying to look up an index on a GDScript before its compiled.

@rune-scape rune-scape requested review from a team as code owners February 23, 2025 10:59
@rune-scape rune-scape changed the title GDScript: Fix error when using a string literal suffix in subscript of class GDScript: Fix error on subscript Class["member"] Feb 23, 2025
@adamscott adamscott modified the milestone: 4.4 Feb 23, 2025
@AThousandShips AThousandShips added bug topic:gdscript cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Feb 24, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Feb 24, 2025
@Repiteo Repiteo added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Feb 24, 2025
@Repiteo Repiteo modified the milestones: 4.4, 4.5 Feb 24, 2025
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release topic:gdscript
Projects
None yet
5 participants