texture_create_from_native_handle() should return RID for texture from RenderingServer, not RenderingDevice
#103296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from `RenderingServer`, not `RenderingDevice`
dsnopek
added
bug
topic:rendering
topic:xr
cherrypick:4.4
akien-mga
approved these changes
Feb 25, 2025
Ok, thanks, I'll adjust the milestone and merge queue! |
dsnopek
removed
the
cherrypick:4.4
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when using a rendering device renderer,
RenderingServer.texture_create_from_native_handle()is returning an RID for an "RD texture" (aka a texture fromRenderingDevice) rather than a texture fromRenderingServer, like it's supposed to.This was my mistake!
This function was introduced by my PR #96928, and I missed a step. Sorry about that!
This PR fixes the issue by wrapping the "RD texture" in a normal texture from
RenderingServer.I also attempted to clarify the note in the docs which explains that if you're targeting only the rendering device renderer, then you can get more control by using
RenderingDevice.texture_create_from_extension()andRenderServer.texture_rd_create().