Add (void *) cast directly to GetProcAddress calls.

[bruvzg]

No description provided.

[akien-mga]

I wonder if it wouldn't be better to put this in typedefs.h so it's always available.
Since it compiles fine on MSVC without (void *) it might be easy to miss in future additions.

[bruvzg]

GCC build in CI should always catch feature additions (and I guess clang-cl as well from now), and I do not think all Windows specific files include typedefs.h, so not sure if it's better. Also, some parts of the code were alredy using direct (void *) cast.

[akien-mga]

Thanks!

[Drako]

From a language standard perspective there is no guarantee that code pointers and data pointers have the same size.
So while dlsym returns a data pointer (which technically shouldn't be cast to a code pointer), GetProcAddress returns a code pointer (which technically shouldn't be cast to a data pointer).

It just so happens that on all major OS used on the common x86, x64, arm and arm64 architectures they do have the same size, so this does work. But if we wanted to be nitpicky, this is undefined behavior.

By the way this is the reason why you have the cast in the first place, because GCC warns about exactly this.
The correct way would be to use the FARPROC type or its definition void (*)() instead of void*.

[bruvzg]

The correct way would be to use the FARPROC type or its definition void (*)() instead of void*.

FARPROC definition is long long int (*)(), and that's what warning is about (cast from 'FARPROC' to 'X' converts to incompatible function type).