Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to prevent crashes when accessing the GameMenu api #103371

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 27, 2025

This should address crashes reported on the Play store. Note that those crashes lack debug symbols which reduces our ability to narrow down the exact cause of the crash. We aim to resolve that in Godot 4.5.

This should address crashes reported on the Play store. Note that those crashes lack debug symbols which reduces our ability to narrow down the exact cause of the crash. We aim to resolve that in Godot 4.5.
@m4gr3d m4gr3d added this to the 4.4 milestone Feb 27, 2025
@m4gr3d m4gr3d requested a review from a team as a code owner February 27, 2025 21:31
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty safe.

@akien-mga akien-mga merged commit 15ff450 into godotengine:master Feb 28, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the add_checks_for_game_menu_utils_jni branch February 28, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants