Fix RemoteTransform2D causing skew to be lost #103377
Open
+29
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
force-pushed
the
fix-RemoteTransform2D-causing-skew-to-be-lost
branch
3 times, most recently
from
8dc6984 to
b75e82f
Compare
|
Is the intention that RemoteTransform2D does not modify skew at all? The skew is still reset if I also wonder if we should add |
Rindbee
force-pushed
the
fix-RemoteTransform2D-causing-skew-to-be-lost
branch
from
b75e82f to
c008480
Compare
|
Setting the skew doesn't seem to be a common use case, and perhaps we should write dedicated code for this case instead of writing generic code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #103368.