-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap Nintendo face buttons on macOS #103661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on macOS 15.2 with a wired Switch Pro controller, it works as expected.
In the joypads demo, pressing A/B used to highlight the opposite button instead (same for X/Y).
Now it highlights the correct location, although the button label appearing on the diagram is wrong since the diagram is designed with Xbox controllers in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. I do not have any Switch controllers to test it.
I should be able to test it shortly! Edit: Works with
It does not work fully with an individual Joy-Con (L) or Joy-Con (R). When held horizontally, the left, up, and right buttons do not register in Godot; the down button registers as "Nintendo Y" (Joypad Button 2). |
This happens for me as well, both before and after these changes. It seems to be a result of moving to the Game Controller framework so I'm not sure if there's a way to work around it. In any case it should be orthogonal to this PR. |
Thanks! |
Cherry-picked for 4.4.1. |
Essentially an update of #89001, as the code that PR is built upon was replaced in #94580.
Fixes #88693.