Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak caused by hidden tooltip controls #103793

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Fix memory leak caused by hidden tooltip controls #103793

merged 1 commit into from
Mar 11, 2025
+1 −0

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Mar 8, 2025 •
edited
Loading

Using hidden controls as flag can override the default tooltip behavior, but these controls are forgotten to be deleted.

You may get a message similar to the following when exiting the editor::

WARNING: 1 RID of type "CanvasItem" was leaked.
     at: _free_rids (servers/rendering/renderer_canvas_cull.cpp:2677)
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object/object.cpp:2381)

@Rindbee
Fix memory leak caused by hidden tooltip controls
ac19f2c 
Using hidden controls can override the default tooltip behavior, but these
controls are forgotten to be deleted.
@Rindbee Rindbee requested a review from a team as a code owner March 8, 2025 05:25
@dalexeev dalexeev added bug topic:gui cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Mar 8, 2025
@dalexeev dalexeev added this to the 4.5 milestone Mar 8, 2025
SaracenOne
SaracenOne approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Repiteo Repiteo merged commit 41a3098 into godotengine:master Mar 11, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 11, 2025

Thanks!

@Rindbee Rindbee deleted the fix-memory-leak-caused-by-hidden-tooltip-controls branch March 11, 2025 23:46
@akien-mga
Copy link
Member

Cherry-picked for 4.4.1.

@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
5 participants
@Rindbee @Repiteo @akien-mga @SaracenOne @dalexeev