Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold Alt/Option key in Project Manager to edit or run project in verbose mode #103875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meorge
Copy link
Contributor

@Meorge Meorge commented Mar 9, 2025

Closes godotengine/godot-proposals#11956.

This PR adds the ability to open projects in verbose mode from the Project Manager. By holding down the Alt/Option key, the "Edit" and "Run" buttons become "Edit (Verbose)" and "Run (Verbose)". Clicking them while holding Alt/Option passes the --verbose flag to the Godot process that the Project Manager runs.

Godot.Project.Manager.Verbose.Mode.1.mp4

Issues

  • As can be seen in the video above, adding "(Verbose)" to the button labels causes the right-hand panel to change its width. This doesn't look very good to me, so I'd like to see if there's a way to keep the width consistent.
  • If the user holds Alt/Option, then selects "Edit in recovery mode", the Project Manager loses track of the Alt/Option key's state. When they click "Cancel" from the recovery mode confirmation window, the Project Manager still thinks that Alt/Option is being held down, and doesn't return to regular "Edit" and "Run" buttons until the user presses and lets go of Alt/Option again.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a tooltip to the Edit/Run buttons to mention that you can hold Alt to enable verbose mode. (Note that on macOS or Linux, this will only have a visible effect for Run if the editor was run from a terminal.)

Also, on Linux, this will not work out of the box on GNOME and Xfce because they use Alt for window manipulation shortcuts by default. There is no way for us to fix this, unless we allow an alternative shortcut like Meta. KDE defaults to Meta for window manipulation since 2022, so it's not affected by this issue anymore.

Therefore, it may be preferable to add the actions with a dropdown menu, similar to what was done for the Edit button in the recovery mode PR.

@Meorge
Copy link
Contributor Author

Meorge commented Mar 10, 2025

Thanks for the info about GNOME and Xfce, and the tooltip suggestion! If possible, I'd definitely like to keep the behavior consistent across platforms, so we don't need documentation that discerns between them. Do you know if Meta could work as a shortcut across all platforms, replacing Alt?

I'd considered adding them with a dropdown similar to recovery mode, but it occurred to me that recovery mode and verbose mode aren't mutually exclusive, and further that if someone is opening a project in recovery mode, they might be more likely to also want the increased info that comes with verbose mode. As such, offering recovery mode and verbose mode as two distinct options wouldn't make sense.

I suppose we could do the following:

  • Edit
    • Edit in verbose mode
    • Edit in recovery mode
    • Edit in recovery + verbose mode

We might also be able to add a check box for verbose mode to the dialog box that shows up explaining recovery mode and confirming that the user wants to use it.

@Calinou
Copy link
Member

Calinou commented Mar 10, 2025

Do you know if Meta could work as a shortcut across all platforms, replacing Alt?

Meta is the Windows key on Windows, so I wouldn't rely on it for anything in Godot. Pressing it will make the Start menu show up after all.

On macOS, it probably works fine, but regardless of the platform, I'd allow both modifiers just in case.

@Meorge Meorge force-pushed the feat/verbose-project-manager branch from c178de5 to dabe1a7 Compare March 20, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to open projects in verbose mode from Project Manager
3 participants