Improve Sphere gizmo performance #103910
Merged
Improve Sphere gizmo performance #103910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiroxas
force-pushed
the
ImproveSphereGizmoPerformance
branch
from
1a6d6d0 to
f9bb2a2
Compare
|
Bumped it to 128 segments, to be like the cylinder one. |
Calinou
reviewed
Mar 10, 2025
Calinou
reviewed
Mar 10, 2025
kiroxas
force-pushed
the
ImproveSphereGizmoPerformance
branch
from
f9bb2a2 to
4915f91
Compare
clayjohn
approved these changes
Mar 10, 2025
|
Thanks! |
This was referenced Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as cylinders and capsule but for sphere shape.
Gains roughly between the two previous one (so around 30x).
Reduced segments from 360 to 64.
With 64 segments
With 360 segments
Like cylinder, if some people do see a difference that bothers them, we can slightly increase it.