Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iteration to Span. #103924

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Add iteration to Span. #103924

merged 1 commit into from
Mar 12, 2025

Conversation

Ivorforce
Copy link
Member

Simple PR to add iteration to Span. I didn't add this to #100293 because it felt out of scope, and I wanted to get it out the door without risking bikeshedding.

The code should speak for itself.

@Ivorforce Ivorforce requested review from a team as code owners March 10, 2025 18:06
@Ivorforce Ivorforce force-pushed the span-iteration branch 2 times, most recently from 87e207f to 7147cc0 Compare March 10, 2025 18:08
@Calinou Calinou added this to the 4.x milestone Mar 10, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Copy link
Contributor

@kiroxas kiroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling for loop syntax with only two lines of code seems like a good trade off !

@akien-mga akien-mga modified the milestones: 4.x, 4.5 Mar 12, 2025
@Repiteo Repiteo merged commit 3fc5390 into godotengine:master Mar 12, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 12, 2025

Thanks!

@Ivorforce Ivorforce deleted the span-iteration branch March 12, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants