Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera2D code cleanup #104136

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Camera2D code cleanup #104136

merged 1 commit into from
Mar 19, 2025
+73 −60

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Mar 14, 2025

  • Removes redundant _is_editing_in_editor() method
  • Removes _set_old_smoothing() (added in 29ea399 with a property, but the property no longer exists)
  • Added set guards
  • Fixed argument names
  • Etc.

@KoBeWi KoBeWi added this to the 4.x milestone Mar 14, 2025
@KoBeWi KoBeWi requested review from a team as code owners March 14, 2025 18:00
@KoBeWi KoBeWi mentioned this pull request Mar 15, 2025
Open
@KoBeWi
Camera2D code cleanup
Loading
Loading status checks…
ecda6b9
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Mar 19, 2025
@akien-mga akien-mga merged commit 9ca0de5 into godotengine:master Mar 19, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the cleaning_camera branch March 19, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KoBeWi @akien-mga