Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Mute Game toggle in the Android Editor #104409

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add support for Mute Game toggle in the Android Editor #104409

merged 1 commit into from
Mar 21, 2025

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Mar 20, 2025 •
edited
Loading

Follow up to #99555, this PR implements Mute Game toggle for the Android editor.

Screenrecorder-2025-03-21-02-32-00-539.mp4

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner March 20, 2025 20:08
@syntaxerror247 syntaxerror247 added this to the 4.5 milestone Mar 20, 2025
m4gr3d
m4gr3d approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Calinou
Calinou approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga merged commit f7dfd64 into godotengine:master Mar 21, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@syntaxerror247 syntaxerror247 deleted the mute-game branch March 21, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:audio topic:editor
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@syntaxerror247 @akien-mga @Calinou @m4gr3d