Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embedded help menu icons. #104441

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Fix embedded help menu icons. #104441

merged 1 commit into from
Mar 24, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 21, 2025

Fixes #104434

@bruvzg bruvzg added this to the 4.5 milestone Mar 21, 2025
ryevdokimov
ryevdokimov suggested changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@ryevdokimov ryevdokimov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help menu is fixed, but the 3D View -> Gizmos menu is still broken. Which I believe is related.

image

@bruvzg
Copy link
Member Author

bruvzg commented Mar 21, 2025

Help menu is fixed, but the 3D View -> Gizmos menu is still broken. Which I believe is related.

This should not be related. #103751 only changed two specific menus. Also, I can't reproduce the issue with Gizmos menu.

@ryevdokimov
Copy link
Contributor

Interesting... I downloaded the artifacts directly from this PR and created a new project. I wonder what is going on then.

@bruvzg
Copy link
Member Author

bruvzg commented Mar 21, 2025 •
edited
Loading

Gizmos issue is likely same as this one #96175 (existed back in 4.3).

@Repiteo Repiteo merged commit 0595bb8 into godotengine:master Mar 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 24, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@ryevdokimov ryevdokimov ryevdokimov approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

The icons in help menu of godot editor is missing
4 participants
@bruvzg @ryevdokimov @Repiteo @akien-mga