Allow users to add items to Tool menu #17576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
akien-mga
reviewed
Mar 17, 2018
editor/editor_node.cpp
Outdated
| @@ -2544,6 +2540,27 @@ void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) { | |||
| } | |||
| } | |||
|
|
|||
| void EditorNode::_tool_menu_option(int p_idx) { | |||
| if (p_idx == 0) { | |||
| orphan_resources->show(); | |||
There was a problem hiding this comment.
I'm not fond of hardcoding what tool options do based on magic numbers from their inserting order.
The previous system let the item register itself as TOOLS_ORPHAN_RESOURCES, the new system should stay similar. The menu item should contain the necessary information to match it to its behaviour, not its index.
|
Thanks for your contribution, it looks great :) |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functions
add_tool_menu_itemandremove_tool_menu_itemwhich were commented out and added logic to them. Also added logic toadd_tool_submenu_item.This allows users to create plugins that add items or submenus to the tools menu under Projects.
Fixes #9969