Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting websocket buffers sizes internally. #29781

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Allow setting websocket buffers sizes internally. #29781

merged 2 commits into from
Jun 17, 2019
+60 −0

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jun 14, 2019

Needed by LSP (#29780).
Could only be set project wise before (#22940).
Should we expose them to GDScript at this point?

@Faless Faless added this to the 3.2 milestone Jun 14, 2019
@Faless Faless requested a review from a team as a code owner June 14, 2019 15:33
@akien-mga
Copy link
Member

I guess binding (and documenting) this might make sense yeah.

@akien-mga akien-mga mentioned this pull request Jun 15, 2019
Closed
2 tasks
@Faless Faless force-pushed the ws/set_buffers_internal branch from 9cfe578 to c812fcb Compare June 15, 2019 15:17
@Faless Faless force-pushed the ws/set_buffers_internal branch from c812fcb to 5b2f098 Compare June 15, 2019 15:21
@Geequlim Geequlim mentioned this pull request Jun 16, 2019
Merged
@akien-mga akien-mga merged commit 363705e into godotengine:master Jun 17, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
discussion enhancement topic:network
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Faless @akien-mga