DirAccessPack: Fix dir_exists and file_exists for res:// paths #31440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both methods check against containers using relative paths as index, so the `res://` part needs to be stripped. Fixes godotengine#26009.
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both methods check against containers using relative paths as index,
so the
res://part needs to be stripped.Fixes #26009.
This is not perfect yet when it comes to
DirAccessPack::file_exists, andFileAccessPack::file_existsis not implemented (like many other methods).I'll work on a thorough test case for the
DirAccessandFileAccessAPIs to ensure that they behave the same on all platforms + packed flavors, or that expected inconsistencies are well documented.