GDScript: Disable LSP if either jsonrpc or websocket are disabled #31741
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
|
Wait that's likely not enough as things get registered in the base module too. |
akien-mga
force-pushed
the
lsp-requires-websocket-jsonrpc
branch
from
e6f2183 to
0e8d29d
Compare
akien-mga
force-pushed
the
lsp-requires-websocket-jsonrpc
branch
from
0e8d29d to
b994124
Compare
akien-mga
changed the title
|
Should be ready for review. |
Geequlim
reviewed
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #29780, solves this comment: #29780 (comment)
CC @Geequlim @ankitpriyarup