Improve icons in the Input Map editor

[Calinou]

• Add a disabled icon for built-in inputs with a tooltip explaining why they can't be removed. This also makes the Add button's horizontal position consistent between built-in and custom inputs.
• Fade out input event icons slightly to make them easier to distinguish from action icons.
• Remove unnecessary punctuation from mouse button and joypad event descriptions.

See godotengine/godot-proposals#303 (comment) for more information.

Preview

[FeatherAntennae]

Pretty nice overhaul!

I'm just not sure about fading the icons. It makes it hard to distinguish between disabled and faded out icons.

Would it be possible to extend the background color of the row instead?

If we kept the same colors as the rows under the buttons, we would immediately know what they are tied to!

[Calinou]

I'm just not sure about fading the icons. It makes it hard to distinguish between disabled and faded out icons.

That was my concern too. On one hand, I'd like to distinguish action icons from individual input icons. It helps the user click the button they actually intended, rather than misreading the list and clicking a button on the wrong row. On the other hand, it's difficult to find a color that doesn't look like the button does something entirely different.

I made another attempt where the action icons used a blue-ish hue obtained by blending the default color and the editor theme's accent color, but it didn't look that great either. What do you think about this? See also my answer below.

Would it be possible to extend the background color of the row instead?

I've tried to do that, but unfortunately, it doesn't work. Icons aren't considered part of the TreeItem column for some reason; I'm not sure if this can be solved without breaking too much stuff.

[FeatherAntennae]

Would it be possible to extend the background color of the row instead?

I've tried to do that, but unfortunately, it doesn't work. Icons aren't considered part of the TreeItem column for some reason; I'm not sure if this can be solved without breaking too much stuff.

If I remember well, the TreeItems in this tree have 3 columns and I think only the first two are given a background color, setting the 3rd column's background doesn't work?

[Calinou]

@FeatherAntennae That's what I meant. Setting the 3rd column's background color results in this:

(I set it to red so the issue is easily visible.)

It seems changing the background color only changes the column's background color up to the icons. Since the column only contains icons, only a tiny part of it is actually colored. The TreeItem only has 3 columns, since both icons are in the same column.

[FeatherAntennae]

@Calinou Hmm, that might be a bug actually.

We could leave it as is for now with your current improvements and open an issue?

[Calinou]

@FeatherAntennae Sounds good to me 🙂

[akien-mga]

Thanks!