Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opengl external textures #36342

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 19, 2020

This PR makes external textures available to Godot shaders.

External textures require the GL_OES_EGL_image_external (GLES2) and GL_OES_EGL_image_external_essl3 (GLES3) extensions, so the custom_defines api is expended so that it can be used by users to include the extension when the shader is compiled.

Use cases
This can be used to embed within Godot games/apps texture(s) that can be painted by the target platform:

  • playing video for all types supported by the target platform (e.g: mp4 video playback in Godot on an Android device)
  • Embedding and displaying webviews provided by the target platform
  • Embedding and displaying views and UIs from the target platform
  • Supporting cameras and ARCore on Android
    ...

Cherry-picks for the 3.2 branch (future 3.2.1) - 3rd batch
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge after the 3.2.1 release.

As dicussed on #35306, this feature won't be added to the master branch for now as it depends on reimplementing GLES2 support and figure out how to use this (if relevant) with Vulkan. We'll do this later on once the master branch is closer to feature complete.

@m4gr3d m4gr3d force-pushed the external_texture_support_for_godot_3_2 branch from 30c413f to 30d738e Compare March 5, 2020 21:10
@akien-mga akien-mga force-pushed the 3.2 branch 3 times, most recently from 8eb193d to 69c1805 Compare March 6, 2020 23:01
@akien-mga akien-mga merged commit cc70b2f into godotengine:3.2 Mar 17, 2020
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the external_texture_support_for_godot_3_2 branch March 17, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants