Check Windows SDK version to use '/permissive-' flag only when supported #36685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
force-pushed
the
windows-sdk-detection
branch
from
c7fa12a to
f8a2f4d
Compare
akien-mga
reviewed
Mar 4, 2020
| @@ -573,6 +573,17 @@ def get_compiler_version(env): | |||
| else: | |||
| return None | |||
|
|
|||
| def compare_version(ver1, ver2): | |||
There was a problem hiding this comment.
There are builtin Python tools for that, see distutils.version.
|
IMO it's better to just remove the flag, we can re-add it with proper checks if we actually need it. |
|
Ok, sounds good. I'll make a new PR to remove the flag completely then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Windows, this change makes sure we don't set '/permissive-' flag with older Windows SDK that don't support it and cause compilation errors in some sdk headers.
Fixes #36671