Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history navigation in the script editor using extra mouse buttons #36910

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 8, 2020

master version of #53067.

This adds history navigation in the script/documentation list. It works exactly like the current implementation using Alt + Left and Alt + Right, but this makes it accessible using the auxiliary mouse buttons present on some mice.

An editor setting allows disabling this feature in case you use the auxiliary mouse buttons for other things (such as push-to-talk in a VoIP program).

@groud
Copy link
Member

groud commented Sep 1, 2021

Sorry for the late review. I think the feature is a good to have, however, I would make disabling of the prev/next mouse button a global setting, not hiding it in the text_editor settings. This also mean we have to check if those shortcuts aren't used anywhere else, so that the disabling works everywhere needed.

@Calinou
Copy link
Member Author

Calinou commented Sep 1, 2021

however, I would make disabling of the prev/next mouse button a global setting, not hiding it in the text_editor settings.

By global setting, do you mean moving the editor setting to another section such as Interface > Editor?

@groud
Copy link
Member

groud commented Sep 1, 2021

By global setting, do you mean moving the editor setting to another section such as Interface > Editor?

Yes.

@Calinou Calinou force-pushed the add-script-nav-extra-mouse-button branch from 11c3a0b to 9652a0b Compare September 1, 2021 18:48
@Calinou
Copy link
Member Author

Calinou commented Sep 1, 2021

Rebased and tested again, it works successfully in both multi-window and single-window modes.

@akien-mga
Copy link
Member

There are CI issues with inconsistent use of override.

@akien-mga
Copy link
Member

There are CI issues with inconsistent use of override.

Bump.

This feature is enabled by default, but it can be disabled in the editor
settings in case it interferes with other uses of the extra buttons
(such as push-to-talk in a VoIP program).
@Calinou Calinou force-pushed the add-script-nav-extra-mouse-button branch from 9652a0b to 3143e7d Compare September 25, 2021 11:33
@akien-mga akien-mga merged commit a5332ca into godotengine:master Sep 25, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the add-script-nav-extra-mouse-button branch September 25, 2021 16:18
@Calinou Calinou removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants