Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/fix packed data API #40748

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Jul 27, 2020

  • Enhance directory API
  • Fix FileAccess::exists() not checking for PackedData being disabled
  • Fix moving to the parent directory (..)
  • Allow absolute paths in existence checks

NOTE: Separate PR submitted for 3.2.


This code is generously donated by IMVU.

@akien-mga
Copy link
Member

You added IMVU submodules :)

- Enhance directory API
- Fix `FileAccess::exists()` not checking for PackedData being disabled
- Fix moving to the parent directory (`..`)
- Allow absolute paths in existence checks
@RandomShaper RandomShaper force-pushed the improve_packed_fs_api branch from 88e666b to f38949a Compare July 27, 2020 10:06
@RandomShaper
Copy link
Member Author

OMG! Fixed.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@akien-mga akien-mga merged commit 32464e5 into godotengine:master Nov 10, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants